You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/04/17 15:32:32 UTC

[2/7] tinkerpop git commit: Re-wording of upgrade docs. CTR

Re-wording of upgrade docs. CTR


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/91a9201f
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/91a9201f
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/91a9201f

Branch: refs/heads/tp32
Commit: 91a9201fb860c78099d11fb9e1c63a2ac32d9cbe
Parents: 70a0eb0
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Apr 17 10:10:52 2017 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Apr 17 10:10:52 2017 -0400

----------------------------------------------------------------------
 .../upgrade/release-3.2.x-incubating.asciidoc    | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/91a9201f/docs/src/upgrade/release-3.2.x-incubating.asciidoc
----------------------------------------------------------------------
diff --git a/docs/src/upgrade/release-3.2.x-incubating.asciidoc b/docs/src/upgrade/release-3.2.x-incubating.asciidoc
index 5b8d70a..4e46ed9 100644
--- a/docs/src/upgrade/release-3.2.x-incubating.asciidoc
+++ b/docs/src/upgrade/release-3.2.x-incubating.asciidoc
@@ -100,14 +100,17 @@ See: link:https://issues.apache.org/jira/browse/TINKERPOP-1387[TINKERPOP-1387]
 
 GraphManager versus DefaultGraphManager
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-The Gremlin-Server previously implemented its own final `GraphManager` class. Now, the `GraphManager` has been 
-updated to an interface, and users can supply their own `GraphManager` implementations in their YAML. The
-previous `GraphManager` class was traditionally only to be used by internal Gremlin-Server classes; however,
-if you previously used the `GraphManager`, then this changeset will be `breaking` for you. To fix the break,
-you can upgrade your code to use the new `DefaultGraphManager`.
-
-The `GraphManager` also deprecated the usage of `getGraphs()` so please use `getGraphNames()` instead.
-The `GraphManager` also deprecated the usage of `getTraversalSources()` so please use `getTraversalSourceNames()` instead.
+Gremlin Server previously implemented its own final `GraphManager` class. Now, the `GraphManager` has been changed to
+an interface, and users can supply their own `GraphManager` implementations in their YAML. The previous `GraphManager`
+class was meant be used by classes internal to Gremlin Server, but it was public so if it was used for some reason by
+usrs then then a compile error can be expected. To correct this problem, which will likely manifest as a compile error
+when trying to create a `new GraphManager()` instance, simply change the code to `new DefaultGraphManager(Settings)`.
+
+In addition to the change mentioned above, several methods on `GraphManager` were deprecated:
+
+* `getGraphs()` should be replaced by the combination of `getGraphNames()` and then `getGraph(String)`
+* `getTraversalSources()` is similarly replaced and should instead use a combinatio of `getTraversalSourceNames()` and
+`getTraversalSource(String)`
 
 See: link:https://issues.apache.org/jira/browse/TINKERPOP-1438[TINKERPOP-1438]