You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by bn...@apache.org on 2005/04/11 17:47:03 UTC
svn commit: r160909 -
httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
Author: bnicholes
Date: Mon Apr 11 08:47:03 2005
New Revision: 160909
URL: http://svn.apache.org/viewcvs?view=rev&rev=160909
Log:
Fix a const/non-const conversion error when building with the strict Metrowerks compiler
Modified:
httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
Modified: httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c?view=diff&r1=160908&r2=160909
==============================================================================
--- httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c (original)
+++ httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c Mon Apr 11 08:47:03 2005
@@ -810,7 +810,7 @@
* (When 'None' is passed, IGNORE_HEADERS_SET && nelts == 0.)
*/
new = (char **)apr_array_push(conf->ignore_headers);
- (*new) = header;
+ (*new) = (char*)header;
}
}
conf->ignore_headers_set = CACHE_IGNORE_HEADERS_SET;
Re: svn commit: r160909 - httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
Posted by Joe Orton <jo...@redhat.com>.
On Mon, Apr 11, 2005 at 03:47:03PM -0000, Brad Nicholes wrote:
> Author: bnicholes
> Date: Mon Apr 11 08:47:03 2005
> New Revision: 160909
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=160909
> Log:
> Fix a const/non-const conversion error when building with the strict Metrowerks compiler
What about the whole voting thing eh? This isn't platform-specific
code. Looks like the correct fix is to have new be a const char **
array in the first place and remove both casts.
>
> Modified:
> httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
>
> Modified: httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c?view=diff&r1=160908&r2=160909
> ==============================================================================
> --- httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c (original)
> +++ httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c Mon Apr 11 08:47:03 2005
> @@ -810,7 +810,7 @@
> * (When 'None' is passed, IGNORE_HEADERS_SET && nelts == 0.)
> */
> new = (char **)apr_array_push(conf->ignore_headers);
> - (*new) = header;
> + (*new) = (char*)header;
> }
> }
> conf->ignore_headers_set = CACHE_IGNORE_HEADERS_SET;
>