[jira] [Commented] (AIRFLOW-6345) ProxyFix fails on 1.10.7 due to TypeError

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003329#comment-17003329 ] 

ASF GitHub Bot commented on AIRFLOW-6345:
-----------------------------------------

dacohen commented on pull request #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [/] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6345
   
   ### Description
   
   - [/] Here are some details about my PR, including screenshots of any UI changes:
   This fixes a type mismatch between the string value returned by the Airflow configuration module, and the integer expected by Werkzeug.
   
   ### Tests
   
   - [/] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Unit tests updated to reflect requirement for integers
   
   ### Commits
   
   - [/] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [/] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ProxyFix fails on 1.10.7 due to TypeError
> -----------------------------------------
>
>                 Key: AIRFLOW-6345
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6345
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.7
>            Reporter: Daniel Cohen
>            Priority: Major
>
> When enabling the Werkzeug ProxyFix middleware on Airflow 1.10.7, the following error is thrown by the webserver on every request:
> {code}
> Traceback (most recent call last):
>  File "/usr/local/lib/python3.6/dist-packages/gunicorn/workers/sync.py", line 135, in handle
>  self.handle_request(listener, req, client, addr)
>  File "/usr/local/lib/python3.6/dist-packages/gunicorn/workers/sync.py", line 176, in handle_request
>  respiter = self.wsgi(environ, resp.start_response)
>  File "/usr/local/lib/python3.6/dist-packages/werkzeug/middleware/dispatcher.py", line 66, in __call__
>  return app(environ, start_response)
>  File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 2463, in __call__
>  return self.wsgi_app(environ, start_response)
>  File "/usr/local/lib/python3.6/dist-packages/werkzeug/middleware/proxy_fix.py", line 200, in __call__
>  self.x_proto, environ_get("HTTP_X_FORWARDED_PROTO")
>  File "/usr/local/lib/python3.6/dist-packages/werkzeug/middleware/proxy_fix.py", line 166, in _get_trusted_comma
>  if len(values) >= trusted:
> TypeError: '>=' not supported between instances of 'int' and 'str'
> {code}
> It appears this regression was caused by AIRFLOW-6188, which made the ProxyFix parameters configurable, but now returns strings instead of the integers expected by Werkzeug, causing the TypeError above.
> I have a PR ready, which I will attach momentarily.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)