You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Andrew Suprun <as...@tucows.com> on 2001/08/23 22:54:46 UTC

[LogKit] ExtendedPatternFormatter bug

Hi guys,
  There is a bug in getTypeIdFor method of ExtendedPatternFormatter
class:

    protected int getTypeIdFor( final String type )
    {
        if( type.equalsIgnoreCase( TYPE_METHOD_STR ) ) return TYPE_METHOD;
        else if( type.equalsIgnoreCase( TYPE_THREAD_STR ) ) return TYPE_THREAD;
        else
        {
            return getTypeIdFor( type );
    //      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        }
    }

  This probably should be something like:

            . . .
            return super.getTypeIdFor( type );
            . . .
    
-- 
Best regards,
 Andrew                            mailto:asuprun@tucows.com



---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org

Re: [LogKit] ExtendedPatternFormatter bug

Posted by Peter Donald <do...@apache.org>.
Hi,

Already fixed in CVS ;) Thanks anyway.

On Fri, 24 Aug 2001 06:54, Andrew Suprun wrote:
> Hi guys,
>   There is a bug in getTypeIdFor method of ExtendedPatternFormatter
> class:
>
>     protected int getTypeIdFor( final String type )
>     {
>         if( type.equalsIgnoreCase( TYPE_METHOD_STR ) ) return TYPE_METHOD;
>         else if( type.equalsIgnoreCase( TYPE_THREAD_STR ) ) return
> TYPE_THREAD; else
>         {
>             return getTypeIdFor( type );
>     //      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>         }
>     }
>
>   This probably should be something like:
>
>             . . .
>             return super.getTypeIdFor( type );
>             . . .

-- 
Cheers,

Pete

*-----------------------------------------------------*
* "Faced with the choice between changing one's mind, *
* and proving that there is no need to do so - almost *
* everyone gets busy on the proof."                   *
*              - John Kenneth Galbraith               *
*-----------------------------------------------------*

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org