[GitHub] [trafficserver] maskit commented on pull request #8963: Http2 to origin

[GitBox <gi...@apache.org>]

maskit commented on PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#issuecomment-1329593036

   @bneradt Is it possible to separate out the change for ConnectionPool and ConnectingEntry?
   
   Since this PR is for H2 to Origin, the code on this PR should not do anything bad unless H2 to Origin is enabled by having `h2`  in `proxy.config.ssl.client.alpn_protocols`. I understand nobody can guarantee that, but ConnectionPool and ConnectingEntry are new and those may affect H1 because the code is used for the both protocols.
   
   As you can see, people who are unfamiliar with H2 haven't been reviewing this PR at all, but the change can bother them. I think you should gather feedback from them as well. Otherwise, we would be blamed like "H2 to Origin made this mess where we don't need it!".
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org