Re: [PR] [SPARK-48229][SQL] Add collation support for inputFile expressions [spark]

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #46503:
URL: https://github.com/apache/spark/pull/46503#discussion_r1597190775


##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1151,6 +1151,23 @@ class CollationSQLExpressionsSuite
     })
   }
 
+  test("Support InputFileName expression with collation") {
+    // Supported collations
+    Seq("UTF8_BINARY", "UTF8_BINARY_LCASE", "UNICODE", "UNICODE_CI").foreach(collationName => {

Review Comment:
   Stopping by this PR, maybe this was discussed a while ago, just curious: why these possible `collationName` is not listed by a enum?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org