You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/23 14:57:22 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24499: chore: remove marshmallow-enum dependency and bump FAB
dpgaspar opened a new pull request, #24499:
URL: https://github.com/apache/superset/pull/24499
### SUMMARY
Marshamallow and marshmallow-apispec support Enum types and since then [marshmallow-enum](https://github.com/justanr/marshmallow_enum) as been archived.
This PR:
- Bumps marshmallow and apispec
- Removes marshmallow-enum dependency, relying on marshmallow `fields.Enum` only
- Bumps Flask-AppBuilder from 4.3.0 to 4.3.3 https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #24499:
URL: https://github.com/apache/superset/pull/24499#discussion_r1242510075
##########
tests/integration_tests/base_api_tests.py:
##########
@@ -115,7 +115,7 @@ def test_default_missing_declaration_put_spec(self):
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_mutation_spec = {
- "properties": {"id": {"format": "int32", "type": "integer"}},
Review Comment:
no, no, the 4.0.0 breaking change is on apispec, it's apispec==4.0.0, major 4 here is only a coincidence with future 4.0.0 on Superset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on PR #24499:
URL: https://github.com/apache/superset/pull/24499#issuecomment-1607616392
> Very nice! I verified that the `configuration_method` error that I was previously seeing on the codegen, where the enum values were missing, is now gone π LGTM
Thank you for raising my attention to this issue, great work @villebro as always
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #24499:
URL: https://github.com/apache/superset/pull/24499#discussion_r1242489302
##########
tests/integration_tests/base_api_tests.py:
##########
@@ -115,7 +115,7 @@ def test_default_missing_declaration_put_spec(self):
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_mutation_spec = {
- "properties": {"id": {"format": "int32", "type": "integer"}},
Review Comment:
@dpgaspar does that mean you're planning on holding off merging this until the next breaking release window?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24499:
URL: https://github.com/apache/superset/pull/24499#issuecomment-1604416178
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24499](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (64c6774) into [master](https://app.codecov.io/gh/apache/superset/commit/2a4ef5cccf3d3f8f2f7ccfc8c590f8f2fde31ab0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2a4ef5c) will **decrease** coverage by `10.99%`.
> The diff coverage is `77.02%`.
> :exclamation: Current head 64c6774 differs from pull request most recent head c651e6f. Consider uploading reports for the commit c651e6f to get more accurate results
```diff
@@ Coverage Diff @@
## master #24499 +/- ##
===========================================
- Coverage 69.03% 58.04% -10.99%
===========================================
Files 1901 1901
Lines 74006 74029 +23
Branches 8115 8119 +4
===========================================
- Hits 51088 42969 -8119
- Misses 20807 28952 +8145
+ Partials 2111 2108 -3
```
| Flag | Coverage Ξ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <100.00%> (-0.01%)` | :arrow_down: |
| python | `60.59% <100.00%> (-22.90%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.65% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `67.07% <0.00%> (ΓΈ)` | |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `59.88% <ΓΈ> (ΓΈ)` | |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...perset-frontend/src/hooks/apiResources/queryApi.ts](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9xdWVyeUFwaS50cw==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXgudHN4) | `62.12% <50.00%> (ΓΈ)` | |
| [...ntend/src/SqlLab/components/TableElement/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC9pbmRleC50c3g=) | `81.92% <73.07%> (+8.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.62% <93.75%> (+0.45%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `91.66% <100.00%> (+1.04%)` | :arrow_up: |
| [superset-frontend/src/hooks/apiResources/tables.ts](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy90YWJsZXMudHM=) | `73.80% <100.00%> (+2.75%)` | :arrow_up: |
| ... and [5 more](https://app.codecov.io/gh/apache/superset/pull/24499?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [298 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24499/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Weβre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24499:
URL: https://github.com/apache/superset/pull/24499#issuecomment-1604697820
Nice!
@dpgaspar Can you remove `marshmallow_enum` from `setup.cfg` and pin `marshmallow` in `install_requires`, `setup.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24499:
URL: https://github.com/apache/superset/pull/24499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on code in PR #24499:
URL: https://github.com/apache/superset/pull/24499#discussion_r1240126543
##########
tests/integration_tests/base_api_tests.py:
##########
@@ -115,7 +115,7 @@ def test_default_missing_declaration_put_spec(self):
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_mutation_spec = {
- "properties": {"id": {"format": "int32", "type": "integer"}},
Review Comment:
@dpgaspar is this a side-effect of how `marshmallow-enum` was encoding the data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #24499:
URL: https://github.com/apache/superset/pull/24499#discussion_r1242149402
##########
tests/integration_tests/base_api_tests.py:
##########
@@ -115,7 +115,7 @@ def test_default_missing_declaration_put_spec(self):
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_mutation_spec = {
- "properties": {"id": {"format": "int32", "type": "integer"}},
Review Comment:
it's actually a change done on apispec: https://github.com/marshmallow-code/apispec/pull/595
breaking change on 4.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #24499: chore: remove marshmallow-enum dependency and bump FAB
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on PR #24499:
URL: https://github.com/apache/superset/pull/24499#issuecomment-1607416838
> Nice! @dpgaspar Can you remove `marshmallow_enum` from `setup.cfg` and pin `marshmallow` in `install_requires`, `setup.py`?
good point, but I don't think we need to pin mashmallow on `setup.py` since we are already pinning flask-appbuilder, and it does that for us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org