You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/13 23:36:49 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #4905:
[missing values] Reverting replacing missing values with zeros
codecov-io edited a comment on issue #4905: [missing values] Reverting replacing missing values with zeros
URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385218464
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=h1) Report
> Merging [#4905](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05be86611785fef2904992e4e7d31dce23f1c51b?src=pr&el=desc) will **decrease** coverage by `8.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4905 +/- ##
==========================================
- Coverage 64.45% 55.77% -8.69%
==========================================
Files 421 344 -77
Lines 20523 9924 -10599
Branches 2245 2245
==========================================
- Hits 13229 5535 -7694
+ Misses 7167 4262 -2905
Partials 127 127
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.4% <ø> (ø)` | :arrow_up: |
| [superset/data/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iaXJ0aF9uYW1lcy5weQ==) | | |
| [superset/data/long\_lat.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9sb25nX2xhdC5weQ==) | | |
| [superset/tasks/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvX19pbml0X18ucHk=) | | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
| [superset/data/bart\_lines.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iYXJ0X2xpbmVzLnB5) | | |
| [superset/data/country\_map.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJ5X21hcC5weQ==) | | |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | | |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | | |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-superset/pull/4905/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=footer). Last update [05be866...7573888](https://codecov.io/gh/apache/incubator-superset/pull/4905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org