You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2009/07/08 22:47:14 UTC

[jira] Created: (PIG-876) limit changes order of order-by to ascending

limit changes order of order-by to ascending
--------------------------------------------

                 Key: PIG-876
                 URL: https://issues.apache.org/jira/browse/PIG-876
             Project: Pig
          Issue Type: Bug
            Reporter: Thejas M Nair
            Assignee: Daniel Dai


grunt> a = load 'students.txt' as (c1,c2,c3,c4);
grunt> s = order a by c1 desc;
grunt> dump s;
(zxldf,M,21,12.56)
(uhsdf,M,34,12.11)
(qwer,F,21,14.44)
(qwer,F,23,145.5)
(oiue,M,54,23.33)
(asdfxc,M,23,12.44)

grunt> l = limit s 3;
grunt> dump l;
(asdfxc,M,23,12.44)
(oiue,M,54,23.33)
(qwer,F,21,14.44)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-876) limit changes order of order-by to ascending

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-876:
---------------------------

    Attachment: PIG-876-1.patch

Need to change sort order of limitAfterSort operator the same as the sort operator.

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-876) limit changes order of order-by to ascending

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729337#action_12729337 ] 

Olga Natkovich commented on PIG-876:
------------------------------------

+ 1 on the patch.

I looked at the unit test failures and they are unrelated to the patch. We have seen this before and it was related to the test automation setup. I will ask our release engineer to take a look

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-876) limit changes order of order-by to ascending

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729066#action_12729066 ] 

Hadoop QA commented on PIG-876:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12412958/PIG-876-1.patch
  against trunk revision 792368.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/117/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/117/console

This message is automatically generated.

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-876) limit changes order of order-by to ascending

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-876:
---------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Patch committed

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-876) limit changes order of order-by to ascending

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730068#action_12730068 ] 

Hudson commented on PIG-876:
----------------------------

Integrated in Pig-trunk #501 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/501/])
    

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-876) limit changes order of order-by to ascending

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-876:
---------------------------

        Fix Version/s: 0.4.0
    Affects Version/s: 0.3.0
               Status: Patch Available  (was: Open)

> limit changes order of order-by to ascending
> --------------------------------------------
>
>                 Key: PIG-876
>                 URL: https://issues.apache.org/jira/browse/PIG-876
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-876-1.patch
>
>
> grunt> a = load 'students.txt' as (c1,c2,c3,c4);
> grunt> s = order a by c1 desc;
> grunt> dump s;
> (zxldf,M,21,12.56)
> (uhsdf,M,34,12.11)
> (qwer,F,21,14.44)
> (qwer,F,23,145.5)
> (oiue,M,54,23.33)
> (asdfxc,M,23,12.44)
> grunt> l = limit s 3;
> grunt> dump l;
> (asdfxc,M,23,12.44)
> (oiue,M,54,23.33)
> (qwer,F,21,14.44)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.