You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bgerrity (via GitHub)" <gi...@apache.org> on 2024/11/19 16:16:26 UTC

[PR] standardize spelling of datacenter [cassandra-gocql-driver]

bgerrity opened a new pull request, #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843

   Keeps the repo internally consistent. The public interface is kept to prevent breakage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2621987610

   @bgerrity can you update your commit message according to our [guidelines](https://github.com/apache/cassandra-gocql-driver/blob/trunk/CONTRIBUTING.md#commit-message)? Then I'll merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2615937167

   @joao-r-reis Think someone else needs to merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2621837598

   I'm good with these changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2627215015

   I'm going to merge https://github.com/apache/cassandra-gocql-driver/pull/1823 in a second and then I'll hold off on merging PRs until we can get this in otherwise changelog conflicts will keep preventing us from merging this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2628077471

   Pushed it past the conflicts again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2631613169

   Pushed again with the rebase and the new commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2564371271

   @martin-sucha Would yo be able to kick the CI here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2623145141

   Rebased and squashed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2579964394

   I'm not seeing an option to trigger the workflow, can you push another commit or rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2622221188

   We typically ask for commits to be squashed into a single commit unless there's a good reason to have multiple commits, also there's a git conflict (I just merged another PR sorry about that).
   
   I can resolve the conflict and do the squashing myself if you don't mind this PR not being considered "merged" by Github (I will still keep you as author of the commit)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2626236559

   @bgerrity sorry there's a conflict with the CHANGELOG.md file. Can you rebase and we can commit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2631604567

   @jameshartig just merged something before I got to this 😢 we really need to change how we update the changelog
   
   @jameshartig let's hold off on merging stuff until we get this one in. @bgerrity sorry to ask you again, one last time I promise. Also can you take the chance and rewrite the commit message title ? "strike datacentre spelling" to "standardize datacenter spelling" maybe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2621826963

   > @joao-r-reis Think someone else needs to merge it.
   
   Yes, I'm waiting for a second +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2622038222

   Oh the `CHANGELOG.md` entry is also missing, sorry didn't check it before


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2622023109

   Fixed the commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "bgerrity (via GitHub)" <gi...@apache.org>.
bgerrity commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-2622096888

   Ok pushed that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-35 standardize spelling of datacenter [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1843:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1843#issuecomment-3070355552

   v2.0.0-rc1 with the fix for this has been released, it would be great if users could try it out and provide feedback on it before 2.0.0 GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org