You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/14 18:40:41 UTC

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5185: Decouple SQLExecutors and JDBC object

codecov-io commented on issue #5185: Decouple SQLExecutors and JDBC object
URL: https://github.com/apache/incubator-shardingsphere/pull/5185#issuecomment-613613234
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=h1) Report
   > Merging [#5185](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/e985dba453776305640158ad7139127912f0e34b&el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `78.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5185      +/-   ##
   ============================================
   - Coverage     54.18%   54.06%   -0.13%     
   + Complexity      406      404       -2     
   ============================================
     Files          1158     1157       -1     
     Lines         20555    20590      +35     
     Branches       3705     3710       +5     
   ============================================
   - Hits          11137    11131       -6     
   - Misses         8727     8765      +38     
   - Partials        691      694       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `60.00% <72.72%> (+4.95%)` | `1.00 <1.00> (+1.00)` | |
   | [...jdbc/core/statement/ShardingPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `74.19% <78.68%> (+1.11%)` | `1.00 <1.00> (+1.00)` | |
   | [...ardingjdbc/executor/PreparedStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `76.19% <100.00%> (-3.18%)` | `0.00 <0.00> (ø)` | |
   | [...phere/shardingjdbc/executor/StatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9TdGF0ZW1lbnRFeGVjdXRvci5qYXZh) | `80.85% <100.00%> (-6.11%)` | `0.00 <0.00> (ø)` | |
   | [...executor/batch/BatchPreparedStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9iYXRjaC9CYXRjaFByZXBhcmVkU3RhdGVtZW50RXhlY3V0b3IuamF2YQ==) | `95.60% <100.00%> (-0.10%)` | `0.00 <0.00> (ø)` | |
   | [.../core/strategy/route/ShardingAlgorithmFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9TaGFyZGluZ0FsZ29yaXRobUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...trategy/StandardShardingStrategyConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9zaGFyZGluZy9zdHJhdGVneS9TdGFuZGFyZFNoYXJkaW5nU3RyYXRlZ3lDb25maWd1cmF0aW9uLmphdmE=) | `62.50% <0.00%> (-37.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...pper/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `82.43% <0.00%> (-13.09%)` | `0.00% <0.00%> (ø%)` | |
   | [...ategy/route/standard/StandardShardingStrategy.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9yb3V0ZS9zdGFuZGFyZC9TdGFuZGFyZFNoYXJkaW5nU3RyYXRlZ3kuamF2YQ==) | `50.00% <0.00%> (-12.97%)` | `0.00% <0.00%> (ø%)` | |
   | [...command/query/text/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9Qb3N0Z3JlU1FMQ29tUXVlcnlFeGVjdXRvci5qYXZh) | `22.58% <0.00%> (-3.23%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=footer). Last update [e985dba...c6fc7cb](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5185?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services