You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2023/01/17 12:14:02 UTC
[GitHub] [bookkeeper] ArsenalKeeper opened a new pull request, #3744: Cancel add EntrylogListener in InterleavedLedgerStorage when SortedLe…
ArsenalKeeper opened a new pull request, #3744:
URL: https://github.com/apache/bookkeeper/pull/3744
#3743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3744: Cancel add EntrylogListener in InterleavedLedgerStorage when SortedLe…
Posted by "dlg99 (via GitHub)" <gi...@apache.org>.
dlg99 commented on code in PR #3744:
URL: https://github.com/apache/bookkeeper/pull/3744#discussion_r1099463921
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -364,8 +364,12 @@ EntryLogManager getEntryLogManager() {
}
void addListener(EntryLogListener listener) {
- if (null != listener) {
- listeners.add(listener);
+ if (null != listener ) {
+ if (!listeners.contains(listener)) {
Review Comment:
when do we add duplicate listeners?
maybe that part should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3744: Cancel add EntrylogListener in InterleavedLedgerStorage when SortedLe…
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #3744:
URL: https://github.com/apache/bookkeeper/pull/3744#issuecomment-1407330634
checkstyle run failed:
Error: /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:367:30: ')' is preceded with whitespace. [ParenPad]
Audit done.
[INFO] There is 1 error reported by Checkstyle 9.3 with buildtools/src/main/resources/bookkeeper/checkstyle.xml ruleset.
Error: src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:[367,30] (whitespace) ParenPad: ')' is preceded with whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org