You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2013/09/17 20:00:28 UTC
Re: Review Request 14041: Patch for KAFKA-1030
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14041/
-----------------------------------------------------------
(Updated Sept. 17, 2013, 6 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1030
Bugs: KAFKA-1030
https://issues.apache.org/jira/browse/KAFKA-1030
Repository: kafka
Description
-------
Using the approach of reading directly from ZK.
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 81bf0bda3229e94ecb6b6aff3ffc9fde852df61b
Diff: https://reviews.apache.org/r/14041/diff/
Testing
-------
unit tests
Thanks,
Guozhang Wang
Re: Review Request 14041: Patch for KAFKA-1030
Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14041/#review26179
-----------------------------------------------------------
Ship it!
Ship It!
- Swapnil Ghike
On Sept. 17, 2013, 6 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14041/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 6 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1030
> https://issues.apache.org/jira/browse/KAFKA-1030
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Using the approach of reading directly from ZK.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 81bf0bda3229e94ecb6b6aff3ffc9fde852df61b
>
> Diff: https://reviews.apache.org/r/14041/diff/
>
>
> Testing
> -------
>
> unit tests
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14041: Patch for KAFKA-1030
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14041/#review26183
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Sept. 17, 2013, 6 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14041/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 6 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1030
> https://issues.apache.org/jira/browse/KAFKA-1030
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Using the approach of reading directly from ZK.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 81bf0bda3229e94ecb6b6aff3ffc9fde852df61b
>
> Diff: https://reviews.apache.org/r/14041/diff/
>
>
> Testing
> -------
>
> unit tests
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14041: Patch for KAFKA-1030
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14041/#review26180
-----------------------------------------------------------
Ship it!
- Neha Narkhede
On Sept. 17, 2013, 6 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14041/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 6 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1030
> https://issues.apache.org/jira/browse/KAFKA-1030
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Using the approach of reading directly from ZK.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 81bf0bda3229e94ecb6b6aff3ffc9fde852df61b
>
> Diff: https://reviews.apache.org/r/14041/diff/
>
>
> Testing
> -------
>
> unit tests
>
>
> Thanks,
>
> Guozhang Wang
>
>