You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 16:16:48 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #8833: ARROW-10803: Support R >= 3.3 and add CI

jonkeane commented on a change in pull request #8833:
URL: https://github.com/apache/arrow/pull/8833#discussion_r555159472



##########
File path: r/configure
##########
@@ -168,6 +162,17 @@ if [ "$ARROW_R_CXXFLAGS" ]; then
 fi
 
 # Test configuration
+CXXCPP="`${R_HOME}/bin/R CMD config CXX11` -E"

Review comment:
       Would it hurt to have this in the `if [TRUE]` block to match what's in the `else` block?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org