You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dthaluru <gi...@git.apache.org> on 2017/07/27 22:33:03 UTC
[GitHub] thrift pull request #1318: Added async nonblocking ssl support in java clien...
GitHub user dthaluru opened a pull request:
https://github.com/apache/thrift/pull/1318
Added async nonblocking ssl support in java client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dthaluru/thrift java-non-blocking
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1318
----
commit 270dfea7162f597efd84f9add754bd1421492bc1
Author: dthaluru <dt...@vmware.com>
Date: 2017-07-26T07:14:08Z
Added async nonblocking SSL support in Java client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
Is there a Jira ticket for this improvement? See: https://thrift.apache.org/docs/HowToContribute
In addition, are the existing unit tests sufficient to cover the changes?
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
@dthaluru, @RandyAbernethy any updates?
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by dthaluru <gi...@git.apache.org>.
Github user dthaluru commented on the issue:
https://github.com/apache/thrift/pull/1318
Sorry for late response. @jeking3 There is no Jira ticket for this feature.
Current unit tests does not cover this feature. Current implementation of non-blocking async java client does not seems to work with blocking java server. To add unit test for this feature, the above mentioned issue need to be fixed. I have talked with @RandyAbernethy offline. I will sent more details in mail.
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
@dthaluru Is there a Jira ticket for this improvement? See: https://thrift.apache.org/docs/HowToContribute
In addition, are the existing unit tests sufficient to cover the changes?
@Jens-G does the current cross suite exercise asynchronous sufficiently to test these changes?
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
It would be nice to see it tested in make cross somehow.
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
@Jens-G does the current cross suite exercise asynchronous sufficiently to test these changes?
---
[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client
Posted by RandyAbernethy <gi...@git.apache.org>.
Github user RandyAbernethy commented on the issue:
https://github.com/apache/thrift/pull/1318
I can get to this this weekend.
---