You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/02/20 23:31:43 UTC
Review Request 31241: Pushing transactions up in QuotaManager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Removing Storage from QuotaManager by pushing transaction layer up the call chain.
Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
Diff: https://reviews.apache.org/r/31241/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73916
-----------------------------------------------------------
Master (70f3bf4) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 24, 2015, 9:04 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:04 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
>
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java bb727214b19ec6074d04eacdd997832e50b756f9
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 34763851cd59996559f160c57b00d23de3dc49b4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 58ae7f8447d354d09adfcef000ee539fcfbb3d3f
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java eac2033cffc09f6a9e867a2499569b51d94f0705
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java daaa759ca5c2cda26802187698f0a33ceb0dd39f
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9d233d16150b3b7f47408b36f927fb2440a10892
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
>
> Diff: https://reviews.apache.org/r/31241/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:04 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Rebased.
Repository: aurora
Description
-------
Removing Storage from QuotaManager by pushing transaction layer up the call chain.
Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java bb727214b19ec6074d04eacdd997832e50b756f9
src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 34763851cd59996559f160c57b00d23de3dc49b4
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 58ae7f8447d354d09adfcef000ee539fcfbb3d3f
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java eac2033cffc09f6a9e867a2499569b51d94f0705
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java daaa759ca5c2cda26802187698f0a33ceb0dd39f
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9d233d16150b3b7f47408b36f927fb2440a10892
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
Diff: https://reviews.apache.org/r/31241/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73373
-----------------------------------------------------------
This patch does not apply cleanly on master (e5de618), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 21, 2015, 12:15 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 12:15 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
>
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
>
> Diff: https://reviews.apache.org/r/31241/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73368
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Feb. 21, 2015, 12:15 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 12:15 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
>
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
>
> Diff: https://reviews.apache.org/r/31241/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 12:15 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Bill's comments.
Repository: aurora
Description
-------
Removing Storage from QuotaManager by pushing transaction layer up the call chain.
Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
Diff: https://reviews.apache.org/r/31241/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Feb. 20, 2015, 10:37 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 77
> > <https://reviews.apache.org/r/31241/diff/1/?file=871169#file871169line77>
> >
> > Would `QuotaStore.Mutable` be sufficient? That would align with LoD.
Done, Though we normally don't use store types in interfaces outside Storage package.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73328
-----------------------------------------------------------
On Feb. 20, 2015, 10:31 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 10:31 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
>
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
>
> Diff: https://reviews.apache.org/r/31241/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31241: Pushing transactions up in QuotaManager.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73328
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
<https://reviews.apache.org/r/31241/#comment119627>
Would `QuotaStore.Mutable` be sufficient? That would align with LoD.
- Bill Farner
On Feb. 20, 2015, 10:31 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 10:31 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
>
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
>
> Diff: https://reviews.apache.org/r/31241/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>