You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/17 10:14:39 UTC

[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request #458: Optimize log message when the endpoint does not have a corresponding service

lingsamuel opened a new pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458


   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Some endpoints doesn't have corresponding services, currently endpoint controller will log massive warning continuously
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842760315


   Mistake branch :joy: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842758166


   @lingsamuel The documentation changes are not related with the purpose of this PR. One PR resolves one thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel removed a comment on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
lingsamuel removed a comment on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842760315


   Mistake branch :joy: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842319124


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#458](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d44af1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5d479ae148d2acdb51082bb0f129548fdfa146b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d479ae) will **increase** coverage by `0.40%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 5d44af1 differs from pull request most recent head 4f6a04c. Consider uploading reports for the commit 4f6a04c to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #458      +/-   ##
   ==========================================
   + Coverage   37.04%   37.44%   +0.40%     
   ==========================================
     Files          47       46       -1     
     Lines        3841     3840       -1     
   ==========================================
   + Hits         1423     1438      +15     
   + Misses       2233     2219      -14     
   + Partials      185      183       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `35.29% <0.00%> (+2.20%)` | :arrow_up: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `32.61% <0.00%> (+5.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4a55307...4f6a04c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
tokers edited a comment on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842758166


   @lingsamuel The documentation changes are not related to the purpose of this PR. One PR resolves one thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-843681580


   Actions failed to start due to [GitHub incidents](https://www.githubstatus.com/incidents/m16jzl31gnqt)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #458: chore: optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842319124


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#458](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d44af1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5d479ae148d2acdb51082bb0f129548fdfa146b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d479ae) will **increase** coverage by `0.40%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 5d44af1 differs from pull request most recent head 4f6a04c. Consider uploading reports for the commit 4f6a04c to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #458      +/-   ##
   ==========================================
   + Coverage   37.04%   37.44%   +0.40%     
   ==========================================
     Files          47       46       -1     
     Lines        3841     3840       -1     
   ==========================================
   + Hits         1423     1438      +15     
   + Misses       2233     2219      -14     
   + Partials      185      183       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `35.29% <0.00%> (+2.20%)` | :arrow_up: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `32.61% <0.00%> (+5.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4a55307...4f6a04c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #458: Optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842202203


   @tokers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #458: Optimize log message when the endpoint does not have a corresponding service

Posted by GitBox <gi...@apache.org>.
lingsamuel commented on pull request #458:
URL: https://github.com/apache/apisix-ingress-controller/pull/458#issuecomment-842202203


   @tokers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org