svn commit: r1050930 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form: EmailTextField.java NumberTextField.java UrlTextField.java

[mg...@apache.org]

Author: mgrigorov
Date: Sun Dec 19 18:55:45 2010
New Revision: 1050930

URL: http://svn.apache.org/viewvc?rev=1050930&view=rev
Log:
WICKET-3241 Add support for the new HTML 5 input types

Javadoc updates

Modified:
    wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EmailTextField.java
    wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
    wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/UrlTextField.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EmailTextField.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EmailTextField.java?rev=1050930&r1=1050929&r2=1050930&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EmailTextField.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EmailTextField.java Sun Dec 19 18:55:45 2010
@@ -22,7 +22,7 @@ import org.apache.wicket.validation.IVal
 import org.apache.wicket.validation.validator.EmailAddressValidator;
 
 /**
- * A {@link TextField} for HTML5 &lt;input&gt; with type <strong>email</strong>.
+ * A {@link TextField} for HTML5 &lt;input&gt; with type <em>email</em>.
  * 
  * <p>
  * Automatically validates that the input is a valid email address.

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java?rev=1050930&r1=1050929&r2=1050930&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java Sun Dec 19 18:55:45 2010
@@ -22,7 +22,7 @@ import org.apache.wicket.util.value.IVal
 import org.apache.wicket.validation.validator.RangeValidator;
 
 /**
- * A {@link TextField} for HTML5 &lt;input&gt; with type <strong>number</strong>.
+ * A {@link TextField} for HTML5 &lt;input&gt; with type <em>number</em>.
  * 
  * <p>
  * Automatically validates the input against the configured {@link #setMinimum(Double) min} and
@@ -56,7 +56,7 @@ public class NumberTextField extends Tex
 	 * @param id
 	 *            see Component
 	 * @param model
-	 *            the model
+	 *            the input value
 	 */
 	public NumberTextField(String id, IModel<Double> model)
 	{
@@ -68,6 +68,8 @@ public class NumberTextField extends Tex
 	}
 
 	/**
+	 * Sets the minimum allowed value
+	 * 
 	 * @param minimum
 	 *            the minimum allowed value
 	 * @return this instance
@@ -79,6 +81,8 @@ public class NumberTextField extends Tex
 	}
 
 	/**
+	 * Sets the maximum allowed value
+	 * 
 	 * @param maximum
 	 *            the maximum allowed value
 	 * @return this instance

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/UrlTextField.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/UrlTextField.java?rev=1050930&r1=1050929&r2=1050930&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/UrlTextField.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/UrlTextField.java Sun Dec 19 18:55:45 2010
@@ -21,7 +21,7 @@ import org.apache.wicket.model.Model;
 import org.apache.wicket.validation.validator.UrlValidator;
 
 /**
- * A {@link TextField} for HTML5 &lt;input&gt; with type <strong>url</strong>.
+ * A {@link TextField} for HTML5 &lt;input&gt; with type <em>url</em>.
  * 
  * <p>
  * Automatically validates the input that it is a valid Url.
@@ -47,16 +47,30 @@ public class UrlTextField extends TextFi
 	 * Construct.
 	 * 
 	 * @param id
-	 *            see Component
+	 *            the component id
 	 * @param model
-	 *            the model
+	 *            the input value
 	 */
 	public UrlTextField(String id, IModel<String> model)
 	{
+		this(id, model, new UrlValidator());
+	}
+
+	/**
+	 * Construct.
+	 * 
+	 * @param id
+	 *            the component id
+	 * @param model
+	 *            the input value
+	 * @param urlValidator
+	 *            the validator that will check the correctness of the input value
+	 */
+	public UrlTextField(String id, IModel<String> model, UrlValidator urlValidator)
+	{
 		super(id, model, String.class);
 
-		// XXX does this validator needs UrlValidator#options ?!
-		add(new UrlValidator());
+		add(urlValidator);
 	}
 
 	@Override