[GitHub] [beam] laraschmidt commented on a change in pull request #16940: [BEAM-14022] Add a logical type for Schema.

[GitBox <gi...@apache.org>]

laraschmidt commented on a change in pull request #16940:
URL: https://github.com/apache/beam/pull/16940#discussion_r821025802



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java
##########
@@ -67,10 +68,13 @@
   private static final String URN_BEAM_LOGICAL_JAVASDK = "beam:logical_type:javasdk:v1";
 
   // TODO(BEAM-7855): Populate this with a LogicalTypeRegistrar, which includes a way to construct
-  // the LogicalType
-  // given an argument.
+  // the LogicalType given an argument.
   private static final ImmutableMap<String, Class<? extends LogicalType<?, ?>>>
-      STANDARD_LOGICAL_TYPES = ImmutableMap.of(MicrosInstant.IDENTIFIER, MicrosInstant.class);
+      STANDARD_LOGICAL_TYPES =
+          ImmutableMap.<String, Class<? extends LogicalType<?, ?>>>builder()
+              .put(MicrosInstant.IDENTIFIER, MicrosInstant.class)
+              .put(SchemaLogicalType.IDENTIFIER, SchemaLogicalType.class)

Review comment:
       done. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org