You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/01/06 15:54:44 UTC
Re: Review Request 38487: Enable JPA statement caching
(internal/external)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:54 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
Changes
-------
updated description, added more reviewers
Bugs: AMBARI-13036
https://issues.apache.org/jira/browse/AMBARI-13036
Repository: ambari
Description (updated)
-------
Problem:
Ambari does not cache database statements which leads to excessive parsing.
Solution:
Added internal and external statement caching feature to Ambari. Caching is not used by default (for c3p0: if max statements is 0, caching is disabled, for insternal caching its decided based on a boolean flag)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java e3686ac
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a40fae6
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 074fbb4
Diff: https://reviews.apache.org/r/38487/diff/
Testing
-------
Unit testing done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:31 h
[INFO] Finished at: 2015-09-17T17:21:55+00:00
[INFO] Final Memory: 48M/605M
[INFO] ------------------------------------------------------------------------
Functional testing:
Locally: done on Postgres & MySQL databases
Thanks,
Oliver Szabo
Re: Review Request 38487: Enable JPA statement caching
(internal/external)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/#review113100
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 6, 2016, 2:54 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38487/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:54 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-13036
> https://issues.apache.org/jira/browse/AMBARI-13036
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
>
> Ambari does not cache database statements which leads to excessive parsing.
>
> Solution:
>
> Added internal and external statement caching feature to Ambari. Caching is not used by default (for c3p0: if max statements is 0, caching is disabled, for insternal caching its decided based on a boolean flag)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java e3686ac
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a40fae6
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 074fbb4
>
> Diff: https://reviews.apache.org/r/38487/diff/
>
>
> Testing
> -------
>
> Unit testing done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:31 h
> [INFO] Finished at: 2015-09-17T17:21:55+00:00
> [INFO] Final Memory: 48M/605M
> [INFO] ------------------------------------------------------------------------
>
> Functional testing:
> Locally: done on Postgres & MySQL databases
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 38487: Enable JPA statement caching
(internal/external)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/#review113127
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 6, 2016, 9:54 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38487/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 9:54 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader.
>
>
> Bugs: AMBARI-13036
> https://issues.apache.org/jira/browse/AMBARI-13036
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
>
> Ambari does not cache database statements which leads to excessive parsing.
>
> Solution:
>
> Added internal and external statement caching feature to Ambari. Caching is not used by default (for c3p0: if max statements is 0, caching is disabled, for insternal caching its decided based on a boolean flag)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java e3686ac
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a40fae6
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 074fbb4
>
> Diff: https://reviews.apache.org/r/38487/diff/
>
>
> Testing
> -------
>
> Unit testing done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:31 h
> [INFO] Finished at: 2015-09-17T17:21:55+00:00
> [INFO] Final Memory: 48M/605M
> [INFO] ------------------------------------------------------------------------
>
> Functional testing:
> Locally: done on Postgres & MySQL databases
>
>
> Thanks,
>
> Oliver Szabo
>
>