You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by Kin-Man Chung <Ki...@Eng.Sun.COM> on 2001/09/21 23:29:27 UTC

[PATCH] TC4.0 Error in setting string literal to Object in custom tags

This patch fixes #3707.

misto% runsocks cvs diff -u "TagBeginGenerator.java"
Index: TagBeginGenerator.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/T
agBeginGenerator.java,v
retrieving revision 1.15
diff -u -r1.15 TagBeginGenerator.java
--- TagBeginGenerator.java      2001/09/07 00:18:49     1.15
+++ TagBeginGenerator.java      2001/09/21 21:18:34
@@ -301,7 +301,7 @@
         } else if (c == Long.class) {
             return "new Long(" + Long.valueOf(s).toString() + "l)";
         } else if (c == Object.class) {
-            return "new String(" + s + ")";
+            return "new String(" + writer.quoteString(s) + ")";
        } else {
            return "(" + c.getName() + 
                ")JspRuntimeLibrary.getValueFromPropertyEditorManager(" +