You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/01/26 20:37:34 UTC

[GitHub] thrift pull request #1081: THRIFT-3854 add a way in java to clear TFramedTra...

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1081#discussion_r98086075
  
    --- Diff: lib/java/test/org/apache/thrift/transport/TestTFastFramedTransport.java ---
    @@ -19,6 +19,8 @@
     package org.apache.thrift.transport;
     
     public class TestTFastFramedTransport extends TestTFramedTransport {
    +  protected final static int INITIAL_CAPACITY = 50;
    +
       @Override
       protected TTransport getTransport(TTransport underlying) {
         return new TFastFramedTransport(underlying, 50, 10 * 1024 * 1024);
    --- End diff --
    
    I think 50 was supposed to be changed to ``INITIAL_CAPACITY`` here, something I could do as part of the merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---