You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/07 19:50:20 UTC
[GitHub] [couchdb] nickva opened a new pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
nickva opened a new pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551
Set the `worker_trap_exits = false` setting to ensure our replication worker pool properly cleans up worker processes.
Ref: https://github.com/apache/couchdb/pull/3208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] iilyak commented on a change in pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
iilyak commented on a change in pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#discussion_r628517446
##########
File path: rebar.config.script
##########
@@ -151,7 +151,7 @@ DepDescs = [
%% Third party deps
{folsom, "folsom", {tag, "CouchDB-0.8.3"}},
{hyper, "hyper", {tag, "CouchDB-2.2.0-6"}},
-{ibrowse, "ibrowse", {tag, "CouchDB-4.0.1-2"}},
+{ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-1"}},
Review comment:
There are dragons there:
- [dump message queue to log](https://github.com/apache/couchdb-ibrowse/blob/CouchDB-4.4.2-1/src/ibrowse.erl#L504)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#issuecomment-836141949
Upstream PR was merged, I created a new ibrowse + our patches release and updated the PR. It now passes the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a change in pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#discussion_r628557062
##########
File path: rebar.config.script
##########
@@ -151,7 +151,7 @@ DepDescs = [
%% Third party deps
{folsom, "folsom", {tag, "CouchDB-0.8.3"}},
{hyper, "hyper", {tag, "CouchDB-2.2.0-6"}},
-{ibrowse, "ibrowse", {tag, "CouchDB-4.0.1-2"}},
+{ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-1"}},
Review comment:
Good idea to check. It looks it won't log unless we configure a logger in the app env:
https://github.com/apache/couchdb-ibrowse/blob/CouchDB-4.4.2-1/src/ibrowse_lib.erl#L443-L446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva edited a comment on pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#issuecomment-834818552
`ibrowse` has unit tests now, which run and pass. However, they use a deprecated `ssl:ssl_accept` function.
PR https://github.com/cmullaparthi/ibrowse/pull/172 for upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] iilyak commented on a change in pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
iilyak commented on a change in pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#discussion_r629244946
##########
File path: rebar.config.script
##########
@@ -151,7 +151,7 @@ DepDescs = [
%% Third party deps
{folsom, "folsom", {tag, "CouchDB-0.8.3"}},
{hyper, "hyper", {tag, "CouchDB-2.2.0-6"}},
-{ibrowse, "ibrowse", {tag, "CouchDB-4.0.1-2"}},
+{ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-1"}},
Review comment:
I did more thorough review of ibrowse source code. There are couple of potential issues. 1) debug/trace mode and 2) dumping of message queue using log_msg. I do agree with you that neither of these would become a problem if we wouldn't configure logger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a change in pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#discussion_r628785442
##########
File path: rebar.config.script
##########
@@ -151,7 +151,7 @@ DepDescs = [
%% Third party deps
{folsom, "folsom", {tag, "CouchDB-0.8.3"}},
{hyper, "hyper", {tag, "CouchDB-2.2.0-6"}},
-{ibrowse, "ibrowse", {tag, "CouchDB-4.0.1-2"}},
+{ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-1"}},
Review comment:
@iilyak would you want to make a PR for upstream to remove that, though with the logging not configured not sure how dangerous it is still?
And we could perhaps also try to upstream the commit to scrub credentials as well. I imagine other users would want to keep credentials not showing up in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#issuecomment-834818552
`ibrowse` has unit tests now, which run and pass. However, they use a deprecated `ssl:ssl_accept` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3551: Bump ibrowse to 4.4.2 + couchdb patches
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3551:
URL: https://github.com/apache/couchdb/pull/3551#issuecomment-836149763
@wohali waiting to resolve https://github.com/apache/couchdb/pull/3551#discussion_r628517446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org