[GitHub] [arrow] wesm commented on pull request #8325: ARROW-10206: [C++][Python][FlightRPC] Allow disabling server validation

[GitBox <gi...@apache.org>]

wesm commented on pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#issuecomment-705851235


   There's some broken stuff for me locally with clang-8
   
   ```
   In file included from /home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:24:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/grpcpp.h:58:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/server.h:22:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/server_impl.h:37:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_interface.h:31:
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/rpc_service_method.h:51:16: error: parameter 'handler_data:' not found in the function declaration [-Werror,-Wdocumentation]
       /// \param handler_data: internal data for the handler.
                  ^~~~~~~~~~~~~
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/rpc_service_method.h:51:16: note: did you mean 'handler_data'?
       /// \param handler_data: internal data for the handler.
                  ^~~~~~~~~~~~~
                  handler_data
   In file included from /home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:24:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/grpcpp.h:58:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/server.h:22:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/server_impl.h:37:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_interface.h:32:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_context_impl.h:41:
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_callback_impl.h:406:18: error: parameter 'ok' not found in the function declaration [-Werror,-Wdocumentation]
     /// \param[in] ok Was it successful? If false, no further write-side operation
                    ^~
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_callback_impl.h:412:18: error: parameter 'ok' not found in the function declaration [-Werror,-Wdocumentation]
     /// \param[in] ok Was it successful? If false, no further read-side operation
                    ^~
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_callback_impl.h:419:18: error: parameter 'ok' not found in the function declaration [-Werror,-Wdocumentation]
     /// \param[in] ok Was it successful? If false, no further write-side operation
                    ^~
   In file included from /home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:24:
   In file included from /home/wesm/cpp-toolchain/include/grpcpp/grpcpp.h:59:
   /home/wesm/cpp-toolchain/include/grpcpp/server_builder.h:131:14: error: parameter 'selected_port[out]' not found in the function declaration [-Werror,-Wdocumentation]
     /// \param selected_port[out] If not `nullptr`, gets populated with the port
                ^~~~~~~~~~~~~~~~~~
   /home/wesm/cpp-toolchain/include/grpcpp/server_builder.h:131:14: note: did you mean 'selected_port'?
     /// \param selected_port[out] If not `nullptr`, gets populated with the port
                ^~~~~~~~~~~~~~~~~~
                selected_port
   /home/wesm/cpp-toolchain/include/grpcpp/server_builder.h:207:8: error: declaration is marked with '\deprecated' command but does not have a deprecation attribute [-Werror,-Wdocumentation-deprecated-sync]
     /// \deprecated For backward compatibility.
         ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   /home/wesm/cpp-toolchain/include/grpcpp/server_builder.h:208:56: note: add a deprecation attribute to the declaration to silence this warning
     ServerBuilder& SetMaxMessageSize(int max_message_size) {
                                                          ^
                                                            __attribute__((deprecated))
   /home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:28:11: error: no member named 'experimental' in namespace 'grpc_impl'; did you mean 'grpc::experimental'?
       const grpc_impl::experimental::TlsCredentialsOptions* options) {
             ^~~~~~~~~~~~~~~~~~~~~~~
             grpc::experimental
   /home/wesm/cpp-toolchain/include/grpcpp/impl/codegen/server_context.h:34:11: note: 'grpc::experimental' declared here
   namespace experimental {
             ^
   /home/wesm/code/arrow/cpp/src/arrow/flight/try_compile/check_tls_opts_127.cc:34:39: error: unused variable 'opt' [-Werror,-Wunused-variable]
     grpc_tls_server_verification_option opt = check(nullptr);
                                         ^
   8 errors generated.
   ninja: build stopped: subcommand failed.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org