You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Dragos Dascalita Haut (JIRA)" <ji...@apache.org> on 2012/06/07 17:20:22 UTC
[jira] [Created] (SLING-2504) custom-login-form bundle is not
working as expected
Dragos Dascalita Haut created SLING-2504:
--------------------------------------------
Summary: custom-login-form bundle is not working as expected
Key: SLING-2504
URL: https://issues.apache.org/jira/browse/SLING-2504
Project: Sling
Issue Type: Bug
Components: Samples
Affects Versions: Form Based Authentication 1.0.0
Reporter: Dragos Dascalita Haut
The custom-login-form doesn't affect the actual login UI.
The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Norman reassigned SLING-2504:
----------------------------------
Assignee: Eric Norman
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Assignee: Eric Norman
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Dragos Dascalita Haut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragos Dascalita Haut resolved SLING-2504.
------------------------------------------
Resolution: Fixed
I've tested the custom-selector-login-form bundle and I've marked this issue as resolved.
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Assignee: Eric Norman
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Dragos Dascalita Haut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292511#comment-13292511 ]
Dragos Dascalita Haut commented on SLING-2504:
----------------------------------------------
I see. I personally though the /system/sling/form/login has been somehow deprecated, seeing that it's not actually used in the samples, neither in the Sling's main index.html page, when users click login.
I'm a bit confused though as to why would Sling expose 2 paths for the same purpose. When should one approach be used and when should the other approach be used ?
If the intent is to keep the 2 approaches then your first point makes sense and adding an additional custom-login-sample would surely help.
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Dragos Dascalita Haut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragos Dascalita Haut updated SLING-2504:
-----------------------------------------
Attachment: fixing_custom_login_form_sample.patch
I'm attaching the patch for this issue.
Changelist:
- updated custom-login-form pom to have the bundle registered as a fragment for org.apache.sling.auth.selector
- moved the custom_login.html from org.apache.sling.form.impl into another package: org.apache.sling.auth.selector
- deleted duplicated login.html file from org.apache.sling.auth.form. The one being used is in org.apache.sling.auth.selector.
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292472#comment-13292472 ]
Eric Norman commented on SLING-2504:
------------------------------------
Thanks for the patch.
I have done a quick review and have some initial thoughts for your consideration.
1. The org.apache.sling.auth.selector bundle may not always be installed. In that case, you would want the custom-login-form to remain as it was before attached to the org.apache.sling.auth.form bundle. So maybe it would make sense to have a second sample for a custom login form attached to the o.a.s.auth.selector bundle?
2. The login.html file from org.apache.sling.auth.form would still be used depending on how the user navigates to the login page so it should not be deleted. For example, if the user navigates directly to /system/sling/form/login vs. /system/sling/selector/login
Does that make sense?
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293123#comment-13293123 ]
Felix Meschberger commented on SLING-2504:
------------------------------------------
To complement what Eric said: The idea of the login selector is actually to have one single mechanism to create login forms while the actual login and authentication is done by the actual, real authentication handlers. This not only means OpenID or form but also other forms like OAuth and you-name-your-authentication-handler ...
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Assignee: Eric Norman
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Dragos Dascalita Haut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295008#comment-13295008 ]
Dragos Dascalita Haut commented on SLING-2504:
----------------------------------------------
Thank you for your comments and commit. Now I have it all cleared in my mind. I've gotten the latest code and the sample seems to working just fine. I guess the issue has been resolved with the commit of samples/custom-selector-login-form.
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Assignee: Eric Norman
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292603#comment-13292603 ]
Eric Norman commented on SLING-2504:
------------------------------------
I added a sample (at samples/custom-selector-login-form) that demonstrates how to customize the login page of the o.a.s.auth.selector login page in revision 1348688.
Please review if that works for you so we can resolve this issue.
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Assignee: Eric Norman
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2504) custom-login-form bundle is not
working as expected
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292601#comment-13292601 ]
Eric Norman commented on SLING-2504:
------------------------------------
Well, the o.a.s.auth.selector technique is really only useful if you intend to support forms based authentication and OpenID authentication and you want the user to be able to choose which of those two to use. It provides a login page that merges the login forms of the auth.form and auth.openid auth bundles into one page.
If your application doesn't need or want to support OpenID auth, then you could uninstall the auth.selector and auth.openid bundles. If you uninstall those bundles, then the login link in the launchpad main page would go to the next available auth handler (ordered by the service ranking) which could be the one in the auth.form bundle (or some other custom auth handler that you have installed).
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira