You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/30 20:55:26 UTC
[GitHub] [orc] autumnust opened a new pull request #923: ORC-1015: Fixing comment: Configuring memory-manager in writer is a public API
autumnust opened a new pull request #923:
URL: https://github.com/apache/orc/pull/923
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Configuring a customized `MemoryManager` is now a public API so changing the comment to reflect the status quo.
This change is separated from another PR under review (https://github.com/apache/orc/pull/922) where the change of the comment is breaking the atomicity of the PR.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This change is separated from another PR under review (https://github.com/apache/orc/pull/922) where the change of the comment is breaking the atomicity of the PR.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
There's no code change but a comment fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #923:
URL: https://github.com/apache/orc/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #923:
URL: https://github.com/apache/orc/pull/923#issuecomment-931743006
You can file a JIRA and ignore it in this PR.
In this PR, if you review all comments in OrcFile.java, this PR is ready for merge. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #923:
URL: https://github.com/apache/orc/pull/923#issuecomment-932694252
Thank you for checking other places in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] autumnust commented on pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #923:
URL: https://github.com/apache/orc/pull/923#issuecomment-931724900
Looks like I need some help here. @dongjoon-hyun
Saw the following issues from the Github Action :
```
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
CMake Error at /usr/local/Cellar/cmake/3.21.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
```
They only surface in the java build within different versions of mac os but not ubuntu. Did we have an image version change recently?
I also found https://github.com/actions/virtual-environments/issues/92 and looks like the image provided is not installed with doxygen by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] autumnust commented on pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #923:
URL: https://github.com/apache/orc/pull/923#issuecomment-931755400
> You can file a JIRA and ignore it in this PR. In this PR, if you review all comments in OrcFile.java, this PR is ready for merge. :)
I didn't spot other things in the same file.
I created this issue https://issues.apache.org/jira/browse/ORC-1016 , I think it is happening in both of my PRs and the newest from Owen so seems very consistently happening. I can try to create a PR with doxygen being explicitly installed to see if that solves it, but I don't have good idea why it wasn't happening earlier since the mac os version is not changed recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #923: ORC-1015: Update `OrcFile.WriterOptions::memory` javadoc
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #923:
URL: https://github.com/apache/orc/pull/923#issuecomment-931708723
I revised the PR description for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org