You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/09/09 06:31:51 UTC
svn commit: r1881580 - in /pdfbox/trunk:
tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java
xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java
Author: tilman
Date: Wed Sep 9 06:31:51 2020
New Revision: 1881580
URL: http://svn.apache.org/viewvc?rev=1881580&view=rev
Log:
PDFBOX-4892: SonarQube fix
Modified:
pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java
Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java?rev=1881580&r1=1881579&r2=1881580&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java (original)
+++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java Wed Sep 9 06:31:51 2020
@@ -51,6 +51,7 @@ import org.apache.pdfbox.rendering.Image
import org.apache.pdfbox.rendering.PDFRenderer;
import org.apache.pdfbox.util.filetypedetector.FileType;
import org.apache.pdfbox.util.filetypedetector.FileTypeDetector;
+import org.junit.Assert;
import org.w3c.dom.Element;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -314,9 +315,9 @@ public class TestImageIOUtils extends Te
private void checkResolution(String filename, int expectedResolution)
throws IOException
{
- assertFalse("Empty file " + filename, new File(filename).length() == 0);
+ Assert.assertNotEquals("Empty file " + filename, 0, new File(filename).length());
String suffix = filename.substring(filename.lastIndexOf('.') + 1);
- if ("BMP".equals(suffix.toUpperCase()))
+ if ("BMP".equalsIgnoreCase(suffix))
{
// BMP reader doesn't work
checkBmpResolution(filename, expectedResolution);
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java?rev=1881580&r1=1881579&r2=1881580&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java Wed Sep 9 06:31:51 2020
@@ -183,7 +183,7 @@ public class XMPMetaDataTest
Calendar createDate1 = basicSchema.getCreateDate();
basicSchema.setCreateDate(new GregorianCalendar());
Calendar createDate2 = basicSchema.getCreateDate();
- Assert.assertFalse("CreateDate has not been set", createDate1.equals(createDate2));
+ Assert.assertNotEquals("CreateDate has not been set", createDate1, createDate2);
// check that bugfix does not interfere with lists of properties with same name
DublinCoreSchema dublinCoreSchema = xmp.getDublinCoreSchema();
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java?rev=1881580&r1=1881579&r2=1881580&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AbstractXMPSchemaTest.java Wed Sep 9 06:31:51 2020
@@ -496,13 +496,12 @@ public abstract class AbstractXMPSchemaT
String img = "/9j/4AAQSkZJRgABAgEASABIAAD";
setMethod.invoke(schema, height, width, format, img);
List<ThumbnailType> found = ((List<ThumbnailType>) getMethod.invoke(schema));
- Assert.assertTrue(found.size() == 1);
+ Assert.assertEquals(1, found.size());
ThumbnailType t1 = found.get(0);
Assert.assertEquals(height, t1.getHeight());
Assert.assertEquals(width, t1.getWidth());
Assert.assertEquals(format, t1.getFormat());
Assert.assertEquals(img, t1.getImage());
-
}
protected void testGetSetLangAltValue() throws Exception