You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2023/06/09 01:51:19 UTC
[GitHub] [nuttx-apps] anchao opened a new pull request, #1787: system/cu: disable error print if DEFAULT_SMALL
anchao opened a new pull request, #1787:
URL: https://github.com/apache/nuttx-apps/pull/1787
## Summary
system/cu: disable error print if DEFAULT_SMALL
Test on sim/nsh (CONFIG_DEFAULT_SMALL=y):
```bash
text data bss dec hex filename
397049 26704 4128 427881 68769 nuttx /* before */
396481 26704 4128 427313 68531 nuttx /* after */
-568
```
## Impact
N/A
## Testing
sim/nsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] patacongo commented on pull request #1787: system/cu: disable error print if DEFAULT_SMALL
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on PR #1787:
URL: https://github.com/apache/nuttx-apps/pull/1787#issuecomment-1583851307
CONFIG_DEFAULT_SMALL should not be used directly control features. See full comment in #1788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] anchao commented on pull request #1787: system/cu: disable error print if SYSTEM_CUTERM_DISABLE_ERROR_PRINT enabled
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #1787:
URL: https://github.com/apache/nuttx-apps/pull/1787#issuecomment-1583884800
> CONFIG_DEFAULT_SMALL should not be used directly control features. See full comment in #1788
I made the corresponding changes according to your suggestion, please review again, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1787: system/cu: disable error print if SYSTEM_CUTERM_DISABLE_ERROR_PRINT enabled
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1787:
URL: https://github.com/apache/nuttx-apps/pull/1787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org