You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinay Kumar Thota (JIRA)" <ji...@apache.org> on 2010/07/23 10:33:50 UTC
[jira] Commented: (MAPREDUCE-1964) Running hi Ram jobs when TTs are
blacklisted
[ https://issues.apache.org/jira/browse/MAPREDUCE-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891519#action_12891519 ]
Vinay Kumar Thota commented on MAPREDUCE-1964:
----------------------------------------------
1. Please add some brief description about class.
2. Add java doc information for each public methods.
3.
{noformat}
+ Assert.assertEquals("Job has not been succeeded",
+ jInfo.getStatus().getRunState(), JobStatus.SUCCEEDED);
{noformat}
don't use the above statement in helper method and it left up to test.
4.
{noformat}
+ private int runTool(Configuration job, Tool tool,
+ String[] jobArgs) throws Exception {
+ int returnStatus = ToolRunner.run(job, tool, jobArgs);
+ return returnStatus;
+ }
{noformat}
Instead of writing the separate method use ToolRunner statement directly.
{noformat}
+ JobID jobId = helper.runHighRamJob(conf,jobClient,remoteJTClient);
{noformat}
final HighRamJobHelper helper = new HighRamJobHelper();
JobID jobId = helper.runHighRamJob(conf,jobClient,remoteJTClient);
Make it final and use it locally instead of defining globally.Because its using only one place in the class.
> Running hi Ram jobs when TTs are blacklisted
> --------------------------------------------
>
> Key: MAPREDUCE-1964
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1964
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Reporter: Balaji Rajagopalan
> Attachments: hiRam_bList_y20.patch
>
>
> More slots are getting reserved for HiRAM job tasks then required
> Blacklist more than 25% TTs across the job. Run high ram job. No java.lang.RuntimeException should be displayed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.