Re: [PR] fix:dup conflict with balance [incubator-pegasus]

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1590:
URL: https://github.com/apache/incubator-pegasus/pull/1590#discussion_r1470667621


##########
src/replica/duplication/duplication_sync_timer.h:
##########
@@ -73,6 +73,11 @@ class duplication_sync_timer
 
     std::vector<replica_ptr> get_all_replicas();
 
+    // duplication_sync_timer is async with replica close,so replica_duplicator_manager may already
+    // release
+    // dup should stop right now
+    bool replica_is_cloing_or_closed(gpid id);

Review Comment:
   The same to https://github.com/apache/incubator-pegasus/pull/1608, you can judge the state of the replica by itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org