You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 13:02:21 UTC
Re: Review Request 68761: Made the actors in resource providers
managed by libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68761/#review213024
-----------------------------------------------------------
Bad review!
Reviews applied: [68761, 68760, 68759]
Error:
2019-02-21 13:02:20 URL:https://reviews.apache.org/r/68761/diff/raw/ [3859/3859] -> "68761.patch" [1]
error: patch failed: src/resource_provider/storage/provider.hpp:17
error: src/resource_provider/storage/provider.hpp: patch does not apply
- Mesos Reviewbot
On Sept. 19, 2018, 4:53 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68761/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2018, 4:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the local resource provider daemon actively destructs local
> resource providers, we should make the actors managed by libprocess
> and avoid blocking waits during resource provider destructions.
>
>
> Diffs
> -----
>
> include/mesos/v1/resource_provider.hpp 15ede9faf96a981427ed8b3f28b170c893507bc5
> src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be
> src/resource_provider/storage/provider.hpp 5a371b19289c6e39fedd4cda65fa8be432d095e6
> src/resource_provider/storage/provider.cpp 6475f653263337c381b6080695d09c49e5ea8fcf
>
>
> Diff: https://reviews.apache.org/r/68761/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>