You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/02/16 23:03:21 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
exceptionfactory opened a new pull request, #6968:
URL: https://github.com/apache/nifi/pull/6968
# Summary
[NIFI-11194](https://issues.apache.org/jira/browse/NIFI-11194) Removes unnecessary gzip processing for CSS and JavaScript files in `nifi-web-ui`, avoiding unnecessary building and packaging steps.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #6968:
URL: https://github.com/apache/nifi/pull/6968#issuecomment-1433884561
The changes look good. Will review closer and verify...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman merged pull request #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #6968:
URL: https://github.com/apache/nifi/pull/6968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #6968:
URL: https://github.com/apache/nifi/pull/6968#issuecomment-1433877105
The Gzip files provided Jetty with the option to stream files that were already compressed, but this feature is deprecated and disabled by default in Jetty 9.4 as described in [Jetty PR 2385](https://github.com/eclipse/jetty.project/pull/2385).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on a diff in pull request #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #6968:
URL: https://github.com/apache/nifi/pull/6968#discussion_r1129762289
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml:
##########
@@ -896,81 +896,45 @@
<packagingIncludes>
assets/**/*,
css/common-ui.css,
- css/common-ui.css.gz,
Review Comment:
Only minor thing I would suggest is to update the comment above to something like...
> Configuration to ensure that we only bundle the aggregated version of static content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6968: NIFI-11194 Remove gzip CSS and JS from nifi-web-ui
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #6968:
URL: https://github.com/apache/nifi/pull/6968#discussion_r1129777336
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml:
##########
@@ -896,81 +896,45 @@
<packagingIncludes>
assets/**/*,
css/common-ui.css,
- css/common-ui.css.gz,
Review Comment:
Thanks @mcgilman, I pushed a commit updating that comment as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org