You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2015/09/10 02:17:16 UTC
svn commit: r1702135 - in
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6:
generic/MethodGen.java verifier/GraphicalVerifier.java
verifier/VerifierAppFrame.java verifier/VerifyDialog.java
Author: ggregory
Date: Thu Sep 10 00:17:15 2015
New Revision: 1702135
URL: http://svn.apache.org/r1702135
Log:
Add final modifier to private fields.
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/GraphicalVerifier.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifierAppFrame.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifyDialog.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java?rev=1702135&r1=1702134&r2=1702135&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java Thu Sep 10 00:17:15 2015
@@ -878,8 +878,8 @@ public class MethodGen extends FieldGenO
static final class BranchStack {
- private Stack<BranchTarget> branchTargets = new Stack<>();
- private Hashtable<InstructionHandle, BranchTarget> visitedTargets = new Hashtable<>();
+ private final Stack<BranchTarget> branchTargets = new Stack<>();
+ private final Hashtable<InstructionHandle, BranchTarget> visitedTargets = new Hashtable<>();
public void push( InstructionHandle target, int stackDepth ) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/GraphicalVerifier.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/GraphicalVerifier.java?rev=1702135&r1=1702134&r2=1702135&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/GraphicalVerifier.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/GraphicalVerifier.java Thu Sep 10 00:17:15 2015
@@ -30,7 +30,7 @@ import org.apache.commons.bcel6.generic.
*/
public class GraphicalVerifier {
- private boolean packFrame = false;
+ private final boolean packFrame = false;
/** Constructor. */
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifierAppFrame.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifierAppFrame.java?rev=1702135&r1=1702134&r2=1702135&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifierAppFrame.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifierAppFrame.java Thu Sep 10 00:17:15 2015
@@ -55,42 +55,42 @@ public class VerifierAppFrame extends JF
private static final String JUSTICE_VERSION = "JustIce by Enver Haase";
private JPanel contentPane;
- private JSplitPane jSplitPane1 = new JSplitPane();
- private JPanel jPanel1 = new JPanel();
- private JPanel jPanel2 = new JPanel();
- private JSplitPane jSplitPane2 = new JSplitPane();
- private JPanel jPanel3 = new JPanel();
- private JList<String> classNamesJList = new JList<>();
- private GridLayout gridLayout1 = new GridLayout();
- private JPanel messagesPanel = new JPanel();
- private GridLayout gridLayout2 = new GridLayout();
- private JMenuBar jMenuBar1 = new JMenuBar();
- private JMenu jMenu1 = new JMenu();
- private JScrollPane jScrollPane1 = new JScrollPane();
- private JScrollPane messagesScrollPane = new JScrollPane();
- private JScrollPane jScrollPane3 = new JScrollPane();
- private GridLayout gridLayout4 = new GridLayout();
- private JScrollPane jScrollPane4 = new JScrollPane();
- private CardLayout cardLayout1 = new CardLayout();
+ private final JSplitPane jSplitPane1 = new JSplitPane();
+ private final JPanel jPanel1 = new JPanel();
+ private final JPanel jPanel2 = new JPanel();
+ private final JSplitPane jSplitPane2 = new JSplitPane();
+ private final JPanel jPanel3 = new JPanel();
+ private final JList<String> classNamesJList = new JList<>();
+ private final GridLayout gridLayout1 = new GridLayout();
+ private final JPanel messagesPanel = new JPanel();
+ private final GridLayout gridLayout2 = new GridLayout();
+ private final JMenuBar jMenuBar1 = new JMenuBar();
+ private final JMenu jMenu1 = new JMenu();
+ private final JScrollPane jScrollPane1 = new JScrollPane();
+ private final JScrollPane messagesScrollPane = new JScrollPane();
+ private final JScrollPane jScrollPane3 = new JScrollPane();
+ private final GridLayout gridLayout4 = new GridLayout();
+ private final JScrollPane jScrollPane4 = new JScrollPane();
+ private final CardLayout cardLayout1 = new CardLayout();
private String current_class;
- private GridLayout gridLayout3 = new GridLayout();
- private JTextPane pass1TextPane = new JTextPane();
- private JTextPane pass2TextPane = new JTextPane();
- private JTextPane messagesTextPane = new JTextPane();
- private JMenuItem newFileMenuItem = new JMenuItem();
- private JSplitPane jSplitPane3 = new JSplitPane();
- private JSplitPane jSplitPane4 = new JSplitPane();
- private JScrollPane jScrollPane2 = new JScrollPane();
- private JScrollPane jScrollPane5 = new JScrollPane();
- private JScrollPane jScrollPane6 = new JScrollPane();
- private JScrollPane jScrollPane7 = new JScrollPane();
- private JList<String> pass3aJList = new JList<>();
- private JList<String> pass3bJList = new JList<>();
- private JTextPane pass3aTextPane = new JTextPane();
- private JTextPane pass3bTextPane = new JTextPane();
- private JMenu jMenu2 = new JMenu();
- private JMenuItem whatisMenuItem = new JMenuItem();
- private JMenuItem aboutMenuItem = new JMenuItem();
+ private final GridLayout gridLayout3 = new GridLayout();
+ private final JTextPane pass1TextPane = new JTextPane();
+ private final JTextPane pass2TextPane = new JTextPane();
+ private final JTextPane messagesTextPane = new JTextPane();
+ private final JMenuItem newFileMenuItem = new JMenuItem();
+ private final JSplitPane jSplitPane3 = new JSplitPane();
+ private final JSplitPane jSplitPane4 = new JSplitPane();
+ private final JScrollPane jScrollPane2 = new JScrollPane();
+ private final JScrollPane jScrollPane5 = new JScrollPane();
+ private final JScrollPane jScrollPane6 = new JScrollPane();
+ private final JScrollPane jScrollPane7 = new JScrollPane();
+ private final JList<String> pass3aJList = new JList<>();
+ private final JList<String> pass3bJList = new JList<>();
+ private final JTextPane pass3aTextPane = new JTextPane();
+ private final JTextPane pass3bTextPane = new JTextPane();
+ private final JMenu jMenu2 = new JMenu();
+ private final JMenuItem whatisMenuItem = new JMenuItem();
+ private final JMenuItem aboutMenuItem = new JMenuItem();
/** Constructor. */
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifyDialog.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifyDialog.java?rev=1702135&r1=1702134&r2=1702135&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifyDialog.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/VerifyDialog.java Thu Sep 10 00:17:15 2015
@@ -53,7 +53,7 @@ public class VerifyDialog extends javax.
/** Machine-generated. */
private javax.swing.JButton ivjPass3Button = null;
/** Machine-generated. */
- private IvjEventHandler ivjEventHandler = new IvjEventHandler();
+ private final IvjEventHandler ivjEventHandler = new IvjEventHandler();
/**
* The class to verify. Default set to 'java.lang.Object'
* in case this class is instantiated via one of the many