[jira] [Commented] (IMPALA-10698) Remove branching based on MetastoreShim.getMajorVersion()

["rongchuan.jin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653934#comment-17653934 ] 

rongchuan.jin commented on IMPALA-10698:
----------------------------------------

As a fact, there are 10+clusters and 400+ computing nodes are still using the impala version that depends on hive 2.x in our prod environment, our hive team does not have plan to ugrade hive version in the short term, and it will be a great challenge for us to continue using impala if community removes hive2.x code. So could you please consider preserving hive2.x code in impala code? Thanks!

> Remove branching based on MetastoreShim.getMajorVersion()
> ---------------------------------------------------------
>
>                 Key: IMPALA-10698
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10698
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Peter Rozsa
>            Priority: Major
>              Labels: newbie, ramp-up
>
> IMPALA-9731 dropped support for Hive 2 and removed most code associated with it.
> However we still have if statements that check MetastoreShim.getMajorVersion().
> One can check it with:
> {noformat}
> git grep getMajorVersion
> {noformat}
> It would be nice to get rid of these because the MetastoreShim.getMajorVersion() == 2 branches are dead code now.
> Moreover, in the test code there are still some places that check for HIVE_MAJOR_VERSION == 2, e.g.:
> https://github.com/apache/impala/blob/c10e7c969dfcc4847a8f7708940f4aa1852dbee4/tests/metadata/test_hms_integration.py#L215
> These can be also removed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org