You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/01/10 14:54:39 UTC
[PR] [CI] In jenkins.cmd_utils.Sh.tee, check for failing subprocess [tvm]
Lunderberg opened a new pull request, #16382:
URL: https://github.com/apache/tvm/pull/16382
Prior to this commit, the `Sh.tee` method was implemented by calling `f"{cmd} | tee"` in `subprocess.run`. While the `check=True` flag was used, the return code was from `tee`, not from the command itself. This causes failures in the command itself to be silently ignored, such as in [this CI
pipeline](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-i386/detail/PR-16183/37/pipeline) in the `ci/scripts/jenkins/s3.py` step.
This commit updates `Sh.tee` to call `subprocess.Popen` for `cmd`, tee the stdout, and check the return code. (Roughly adapted from [this stackoverflow post](https://stackoverflow.com/a/56484734).)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] In jenkins.cmd_utils.Sh.tee, check for failing subprocess [tvm]
Posted by "vinx13 (via GitHub)" <gi...@apache.org>.
vinx13 merged PR #16382:
URL: https://github.com/apache/tvm/pull/16382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org