[jira] [Commented] (KAFKA-83) Options in SyncProducerConfig and AsyncProducerConfig can leak

["Neha Narkhede (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079704#comment-13079704 ] 

Neha Narkhede commented on KAFKA-83:
------------------------------------

Looks great. 
+1

> Options in SyncProducerConfig and AsyncProducerConfig can leak
> --------------------------------------------------------------
>
>                 Key: KAFKA-83
>                 URL: https://issues.apache.org/jira/browse/KAFKA-83
>             Project: Kafka
>          Issue Type: Bug
>          Components: config
>    Affects Versions: 0.6, 0.7
>            Reporter: Joel Koshy
>            Priority: Minor
>         Attachments: kafka-83.patch, kafkaproducerconfig.pdf
>
>
> There is the high-level producer api, and then there is the sync producer and then there is the async producer. Some config options are shared across these which leads to a small degree of confusion. I have a diagram lying around that I can attach to this jira. Anyway, due to this sharing the ProducerPool code copies around properties which is unsafe, because a developer who adds a new option may forget to copy it over. The fix is simple and should make the preceding summary a bit more clear.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira