[jira] Commented: (SHINDIG-780) implement requestShareApp as a gadgets.rpc callback

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661824#action_12661824 ] 

Henning Schmiedehausen commented on SHINDIG-780:
------------------------------------------------

Hi Bob,

I assume that requestShareApp is a pretty container specific implementation. I tried to understand your patch but it contains a lot of "shuffling around" changes, so I could not really follow it all the way through.

For our container e.g. this triggers a flow through our UI because the "share app" information is stored in a different place. I assumed that the "not implemented" is a placeholder where you must add your own, container specific code.

Also, does this patch only work with the jsonrpc container or also with the restful one?

> implement requestShareApp as a gadgets.rpc callback
> ---------------------------------------------------
>
>                 Key: SHINDIG-780
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-780
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript), OpenSocial  feature (Javascript)
>            Reporter: Bob Evans
>            Assignee: Kevin Brown
>            Priority: Critical
>             Fix For: trunk
>
>         Attachments: fix-780-bug.patch
>
>
> Currently requestShareApp returns Not Implemented. It would be great to have an implementation that calls out to the outer page (container) via rpc to let it display a dialog for picking friends to send a request for sharing an app.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.