[GitHub] [flink] dianfu commented on a diff in pull request #19987: [FLINK-28090][table] Support attachAsDataStream

[GitBox <gi...@apache.org>]

dianfu commented on code in PR #19987:
URL: https://github.com/apache/flink/pull/19987#discussion_r901446861


##########
flink-python/pyflink/table/statement_set.py:
##########
@@ -50,6 +50,13 @@ def add_insert_sql(self, stmt: str) -> 'StatementSet':
         """
         self._j_statement_set.addInsertSql(stmt)
         return self
+    
+    def attach_as_datastream(self: StatementSet):

Review Comment:
   Could you also update the documentation here: https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/data_stream_api/#adding-table-api-pipelines-to-datastream-api



##########
flink-python/pyflink/table/statement_set.py:
##########
@@ -50,6 +50,13 @@ def add_insert_sql(self, stmt: str) -> 'StatementSet':
         """
         self._j_statement_set.addInsertSql(stmt)
         return self
+    
+    def attach_as_datastream(self: StatementSet):
+        """
+        combine table api statements into datastream

Review Comment:
   Could we reference the documentation from the Java attachAsDataStream?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org