You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by di...@apache.org on 2024/04/16 11:21:23 UTC

(superset) branch geido/fix/edit-chart-new-window updated: Clean up

This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a commit to branch geido/fix/edit-chart-new-window
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/geido/fix/edit-chart-new-window by this push:
     new dfce4bd158 Clean up
dfce4bd158 is described below

commit dfce4bd158c4971ba109d36c6f9a7612012c1deb
Author: Diego Pucci <di...@gmail.com>
AuthorDate: Tue Apr 16 13:21:12 2024 +0200

    Clean up
---
 .../src/dashboard/components/SliceHeaderControls/index.tsx              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
index e546b51f0c..e3a5db0ca7 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
@@ -529,6 +529,7 @@ const SliceHeaderControls = (props: SliceHeaderControlsPropsWithRouter) => {
   const [openScopingModal, scopingModal] = useCrossFiltersScopingModal(
     props.slice.slice_id,
   );
+  const history = useHistory();
 
   const queryMenuRef: RefObject<any> = useRef(null);
   const menuRef: RefObject<any> = useRef(null);
@@ -677,7 +678,6 @@ const SliceHeaderControls = (props: SliceHeaderControlsPropsWithRouter) => {
     supersetCanShare = false,
     isCached = [],
   } = props;
-  const history = useHistory();
   const isTable = slice.viz_type === 'table';
   const cachedWhen = (cachedDttm || []).map(itemCachedDttm =>
     moment.utc(itemCachedDttm).fromNow(),