[GitHub] [pulsar-client-node] massakam commented on pull request #302: [fix] Fix error when falling back to local build

["massakam (via GitHub)" <gi...@apache.org>]

massakam commented on PR #302:
URL: https://github.com/apache/pulsar-client-node/pull/302#issuecomment-1453259791

   @shibd
   
   > If this PR is merged, this behavior will be changed. If you install `1.9.0-rc.1` (not yet released), the local cpp client version is 2.8.0 (old), and the build may fail.
   
   Hmm, I don't quite understand your concerns... Currently, that build always fails if there is no C++ library under the `pkg` directory, right? When this PR is merged, if there is a library under `pkg` it will be used, otherwise the library installed on the local machine will be used. If the installed library version is high enough, it will succeed. In other words, it increases the chances of a successful build.
   
   Are you concerned that the version of the installed C++ library is not the expected one, resulting in successful compilation but unexpected behavior?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org