You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/04 18:28:05 UTC
[kudu-CR] Reintroduce TSAN suppression for epoll ctl
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4618
to review the following change.
Change subject: Reintroduce TSAN suppression for epoll_ctl
......................................................................
Reintroduce TSAN suppression for epoll_ctl
Since 407f95da1254 a few spurious TSAN errors have surfaced from libev /
epoll_ctl.
See also:
* An example race: https://gist.github.com/danburkert/869809cb91ba8cae4ff80c671a3bc232
* The original commit introducing a suppression on ev_ctl: https://gerrit.cloudera.org/#/c/1793/
Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
---
M build-support/tsan-suppressions.txt
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4618/1
--
To view, visit http://gerrit.cloudera.org:8080/4618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reintroduce TSAN suppression for epoll ctl
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Reintroduce TSAN suppression for epoll_ctl
......................................................................
Reintroduce TSAN suppression for epoll_ctl
Since 407f95da1254 a few spurious TSAN errors have surfaced from libev /
epoll_ctl.
See also:
* An example race: https://gist.github.com/danburkert/869809cb91ba8cae4ff80c671a3bc232
* The original commit introducing a suppression on ev_ctl: https://gerrit.cloudera.org/#/c/1793/
Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Reviewed-on: http://gerrit.cloudera.org:8080/4618
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Dan Burkert <da...@cloudera.com>
---
M build-support/tsan-suppressions.txt
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reintroduce TSAN suppression for epoll ctl
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Reintroduce TSAN suppression for epoll_ctl
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reintroduce TSAN suppression for epoll ctl
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reintroduce TSAN suppression for epoll_ctl
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reintroduce TSAN suppression for epoll ctl
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reintroduce TSAN suppression for epoll_ctl
......................................................................
Patch Set 1:
This is starting to come back to me now. There is some craziness with epoll FDs when a child closes the duped file descriptor: https://lkml.org/lkml/2007/10/27/25
It seems libev works around this issue by detecting it and re-registering file descriptors, which is perhaps what TSAN is detecting (since ev doesn't use atomics that TSAN can see)
--
To view, visit http://gerrit.cloudera.org:8080/4618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No