You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/21 00:28:15 UTC

[GitHub] zeppelin pull request #1053: [ZEPPELIN-1039] updated CreateNewButton Testcas...

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1053

    [ZEPPELIN-1039] updated CreateNewButton Testcase in ParagraphAction 

    ### What is this PR for?
    https://github.com/apache/zeppelin/commit/dec31d69efc3d167bb1f5ac91b26478f307414fb
    After updating the code, and test cases fail.
    The code was modified to add code to the test.
    
    The interpreter automatically name is added, and therefore empty para graph is not generated.
    ```
    testCreateNewButton(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 11.069 sec  <<< FAILURE!
    java.lang.AssertionError: Paragraph is created above
    Expected: ""
         but: was "%spark "
    	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    	at org.junit.Assert.assertThat(Assert.java:865)
    	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    	at org.apache.zeppelin.integration.ParagraphActionsIT.testCreateNewButton(ParagraphActionsIT.java:95)
    
    testCreateNewButton(org.apache.zeppelin.integration.ParagraphActionsIT)  Time elapsed: 11.069 sec  <<< FAILURE!
    java.lang.AssertionError: Paragraph is created below
    Expected: ""
         but: was "%spark "
    	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    	at org.junit.Assert.assertThat(Assert.java:865)
    	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    	at org.apache.zeppelin.integration.ParagraphActionsIT.testCreateNewButton(ParagraphActionsIT.java:105)
    ```
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Updated Test case (createNewButton - ParagraphActionsIT.java)
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1039
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin fixed/paragraphActionsIT-AutomaticallyintpTag

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit bbff0342c8bf8f92a12aa4f698eebb68bd5f425b
Author: CloverHearts <cl...@gmail.com>
Date:   2016-06-20T18:49:43Z

    modifed paragraphActionIT Test case -  automatically interpreter tag.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1053: [ZEPPELIN-1039] updated CreateNewButton Testcase in Pa...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1053
  
    +1 for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1053: [ZEPPELIN-1039] updated CreateNewButton Testcase in Pa...

Posted by minahlee <gi...@git.apache.org>.

Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1053
  
    Merging it as hotfix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1053: [ZEPPELIN-1039] updated CreateNewButton Testcas...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1053


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---