You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/09 22:22:53 UTC
[GitHub] [couchdb] nickva opened a new pull request #3211: Properly combine base and extra headers when making replicator requests
nickva opened a new pull request #3211:
URL: https://github.com/apache/couchdb/pull/3211
Previously we subtly relied on one set of headers being sorted, then sorted the other set of headers, and ran `lists:ukeymerge/3`. That function, however, needs both arguments to be sorted in order for it to work as expected. If one argument wasn't sorted we could get duplicate headers easily, which is what was observed in testing.
A better fix than just sorting both sets of keys, is to use an actual header processing library to combine them so we can account for case insensitivity as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] tonysun83 commented on pull request #3211: Properly combine base and extra headers when making replicator requests
Posted by GitBox <gi...@apache.org>.
tonysun83 commented on pull request #3211:
URL: https://github.com/apache/couchdb/pull/3211#issuecomment-706432005
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3211: Properly combine base and extra headers when making replicator requests
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3211:
URL: https://github.com/apache/couchdb/pull/3211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org