[GitHub] [spark] gaborgsomogyi commented on issue #24627: [SPARK-27748][SS] Kafka consumer/producer password/token redaction.

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on issue #24627: [SPARK-27748][SS] Kafka consumer/producer password/token redaction.
URL: https://github.com/apache/spark/pull/24627#issuecomment-494288631
 
 
   > So IMHO we don't even need to print out all configurations.
   
   Without printing out all the configurations I'm wondering how do you think one can find out why a consumer/producer creation fail?
   
   > explicit ID (as #19096 introduces) would work better and much helpful to debug.
   
   I agree, introducing an ID would be enough but only when consumer/producer already created. Such case not necessary to log all configurations. This is the next PR in my queue but didn't want to mix up the 2 changes.
   
   > Kafka module is too verbose on configuration, especially KafkaConfigUpdater.
   
   Yeah, this can be discussed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org