You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2023/08/11 17:10:22 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #8278: Core: Ability to disable column stats filtering in DeleteFileIndex

rdblue commented on code in PR #8278:
URL: https://github.com/apache/iceberg/pull/8278#discussion_r1291602022


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -231,6 +231,10 @@ private TableProperties() {}
   public static final String ORC_BATCH_SIZE = "read.orc.vectorization.batch-size";
   public static final int ORC_BATCH_SIZE_DEFAULT = 5000;
 
+  public static final String DELETE_COLUMN_STATS_FILTERING_ENABLED =
+      "read.delete.column-stats-filtering.enabled";

Review Comment:
   I don't think that we should have an option to do this.
   
   What we talked about was only applying stats filtering if the min and max file are the same, and otherwise disabling it. Why have an option when we know what the setting should be?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org