You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/07/09 14:42:52 UTC

[GitHub] zeppelin pull request #1158: [ZEPPELIN-1131] Does not initialize login page ...

GitHub user astroshim opened a pull request:

    https://github.com/apache/zeppelin/pull/1158

    [ZEPPELIN-1131] Does not initialize login page values.

    ### What is this PR for?
    This PR is for initialization of login page values(id, password).
    The login id and password does not initialize even if login page closed.
    
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1131
    
    
    ### How should this be tested?
    1. click login.
    2. put id and password.
    3. just close the modal window.
    4. reopen login modal.
    5. id and password should be initialized.
    
    ### Screenshots (if appropriate)
    - before
    ![before](https://cloud.githubusercontent.com/assets/3348133/16708435/b3ce4e32-462e-11e6-8065-f4e57e1c91f0.gif)
    
    
    - after
    ![after](https://cloud.githubusercontent.com/assets/3348133/16708433/9f70238e-462e-11e6-9735-5801bd7bc856.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1131

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1158
    
----
commit 50d5853fe37ae3498a5342ed3c34006dfbbf6447
Author: astroshim <hs...@nflabs.com>
Date:   2016-07-09T14:25:29Z

    init login page values when modal is closed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1158: [ZEPPELIN-1131] Does not initialize login page values.

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1158
  
    LGTM. Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1158: [ZEPPELIN-1131] Does not initialize login page values.

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1158
  
    @astroshim, CI failure seems unrelated LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1158: [ZEPPELIN-1131] Does not initialize login page ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1158: [ZEPPELIN-1131] Does not initialize login page values.

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/1158
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---