You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2024/11/22 09:12:32 UTC
(kyuubi) branch branch-1.10 updated: [KYUUBI #6820] Explicitly disable attach-scaladocs for pure Java modules
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.10
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.10 by this push:
new cac7a0832f [KYUUBI #6820] Explicitly disable attach-scaladocs for pure Java modules
cac7a0832f is described below
commit cac7a0832ff2bd4481ad3d6d8f675d49f32b215c
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Fri Nov 22 17:12:00 2024 +0800
[KYUUBI #6820] Explicitly disable attach-scaladocs for pure Java modules
# :mag: Description
```
export JAVA_HOME=/path/of/openjdk-17
build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false
```
```
[INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs) kyuubi-server-plugin ---
[INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null)
error: fatal error: object scala in compiler mirror not found.
```
## Types of changes :bookmark:
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
Successfully run the build command
```
export JAVA_HOME=/path/of/openjdk-17
build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false
```
---
# Checklist ๐
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
Closes #6820 from pan3793/scaladoc.
Closes #6820
f5cee3429 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java modules
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
(cherry picked from commit 4b506f4cb92f8102f0d0ca9908869cdedbeb07e5)
Signed-off-by: Cheng Pan <ch...@apache.org>
---
extensions/flink/kyuubi-flink-token-provider/pom.xml | 9 ++++++---
extensions/server/kyuubi-server-plugin/pom.xml | 9 ++++++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/extensions/flink/kyuubi-flink-token-provider/pom.xml b/extensions/flink/kyuubi-flink-token-provider/pom.xml
index 44a53a2edb..ebb3dad68f 100644
--- a/extensions/flink/kyuubi-flink-token-provider/pom.xml
+++ b/extensions/flink/kyuubi-flink-token-provider/pom.xml
@@ -69,9 +69,12 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
+ <executions>
+ <execution>
+ <id>attach-scaladocs</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
</plugin>
</plugins>
</build>
diff --git a/extensions/server/kyuubi-server-plugin/pom.xml b/extensions/server/kyuubi-server-plugin/pom.xml
index b18f7be583..0807eadb63 100644
--- a/extensions/server/kyuubi-server-plugin/pom.xml
+++ b/extensions/server/kyuubi-server-plugin/pom.xml
@@ -35,9 +35,12 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
+ <executions>
+ <execution>
+ <id>attach-scaladocs</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
</plugin>
</plugins>
</build>