You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/16 16:10:32 UTC
[GitHub] [pulsar] merlimat commented on a change in pull request #9598: Make `LocalPolicies` immutable to avoid concurrent modify inconsistent.
merlimat commented on a change in pull request #9598:
URL: https://github.com/apache/pulsar/pull/9598#discussion_r576944627
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/LocalPolicies.java
##########
@@ -52,4 +60,12 @@ public boolean equals(Object obj) {
return false;
}
+ @Override
+ public String toString() {
Review comment:
Also we could similarly take out the `equals()` and `hashCode()` methods.
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/LocalPolicies.java
##########
@@ -52,4 +60,12 @@ public boolean equals(Object obj) {
return false;
}
+ @Override
+ public String toString() {
Review comment:
Use `@ToString()` annotation on the class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org