[GitHub] [arrow] kou commented on a diff in pull request #13048: MINOR: [Release] Don't install go if it can be located

[GitBox <gi...@apache.org>]

kou commented on code in PR #13048:
URL: https://github.com/apache/arrow/pull/13048#discussion_r863136206


##########
dev/release/verify-release-candidate.sh:
##########
@@ -382,6 +382,11 @@ install_go() {
     return 0
   fi
 
+  if which go > /dev/null 2>&1; then
+    show_info "Found $(go version) at $(which go)"

Review Comment:
   Could you use `command -v` instead of `which` because `command -v` is implemented in all POSIX compatible shells but `which` is an external command?
   
   ```suggestion
     if command -v go > /dev/null; then
       show_info "Found $(go version) at $(command -v go)"
   ```
   
   (I know that we already use `which` in this script. :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org