You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 07:31:56 UTC
[GitHub] [incubator-superset] cyw233 opened a new pull request #10841: update all python version in the Dockerfile to 3.7
cyw233 opened a new pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
Yeah I did some research on Ubuntu 20.04. It by default has Python 3.8 along with Python 2.7. So I guess I will first change the description to:
"**Ubuntu 20.04** If you have python3.7 installed alongside with python2.7, run this command also:"
Then I will change "python3.6-dev" to "python3.7-dev". So the install command will be changed to
`sudo apt-get install build-essential libssl-dev libffi-dev python3.7-dev python-pip libsasl2-dev libldap2-dev`
Is there anything else I need to change? Cheers!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690934177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
Actually it's simpler than that, `ubuntu-20.04` ships with 3.8 only, no 2.7. So I think this can be rephrased as
> *Ubuntu 20.04* the following command will ensure that the required dependencies are installed:
`sudo apt-get install build-essential libssl-dev libffi-dev python3-dev python-pip libsasl2-dev libldap2-dev`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
Yeah I did some research on Ubuntu 20.04. It by default has Python 3.8 along with Python 2.7. So I guess I will first change the description to:
"**Ubuntu 20.04** If you have python3.8 installed alongside with python2.7, as is default on Ubuntu 20.04 LTS, run this command also:"
Then I will change "python3.6-dev" to "python3.8-dev". So the install command will be changed to
`sudo apt-get install build-essential libssl-dev libffi-dev python3.8-dev python-pip libsasl2-dev libldap2-dev`
Is there anything else I need to change? Cheers!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691017085
Change made. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690934177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
Yeah I did some research on Ubuntu 20.04. It by default has Python 3.8 along with Python 2.7. So I guess I will first change the description to:
"**Ubuntu 20.04** If you have python3.8 installed alongside with python2.7, as is default on Ubuntu 20.04 LTS, run this command also:"
Then I will change "python3.6-dev" to "python3.7-dev". So the install command will be changed to
`sudo apt-get install build-essential libssl-dev libffi-dev python3.7-dev python-pip libsasl2-dev libldap2-dev`
Is there anything else I need to change? Cheers!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
Actually it's simpler than that, `ubuntu-20.04` ships with 3.8 only, no 2.7. So I think this can be rephrased as
> Ubuntu 20.04, the following command will ensure that the required dependencies are installed:
`sudo apt-get install build-essential libssl-dev libffi-dev python3-dev python-pip libsasl2-dev libldap2-dev`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690934177
I did some more searching, and found 3.6 also being mentioned in `docs/installation.rst`. We should probably update the reference to `ubuntu-20.04` which ships with Python 3.8 by default, as it's the current LTS version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-691014811
Actually it's simpler than that, `ubuntu-20.04` ships with 3.8 only, no 2.7. So I think this can be rephrased as
> **Ubuntu 20.04** the following command will ensure that the required dependencies are installed:
`sudo apt-get install build-essential libssl-dev libffi-dev python3-dev python-pip libsasl2-dev libldap2-dev`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
Yeah I did some research on Ubuntu 20.04. It by default has Python 3.8 along with Python 2.7. So I guess I will first change the description to:
"**Ubuntu 20.04** If you have python3.8 installed alongside with python2.7, run this command also:"
Then I will change "python3.6-dev" to "python3.8-dev". So the install command will be changed to
`sudo apt-get install build-essential libssl-dev libffi-dev python3.8-dev python-pip libsasl2-dev libldap2-dev`
Is there anything else I need to change? Cheers!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 edited a comment on pull request #10841: update all python version in the Dockerfile to 3.7
Posted by GitBox <gi...@apache.org>.
cyw233 edited a comment on pull request #10841:
URL: https://github.com/apache/incubator-superset/pull/10841#issuecomment-690951282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org